test(server): cover DNS rebinding deployment guidance#105
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #105 +/- ##
==========================================
+ Coverage 80.64% 80.84% +0.20%
==========================================
Files 43 43
Lines 5801 5801
==========================================
+ Hits 4678 4690 +12
+ Misses 1123 1111 -12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR expands security-focused coverage and documentation for Streamable HTTP transports, specifically around DNS rebinding protections and safer deployment/migration guidance.
Changes:
- Adds Streamable HTTP DNS rebinding tests covering allowlisted Host/Origin and blocked Host/Origin behavior.
- Documents local-development and production deployment recipes with explicit Host/Origin allowlists.
- Updates “strict defaults / compatibility toggle” guidance to discourage disabling DNS rebinding protection during migrations.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
test/server/streamable_https_test.dart |
Adds DNS rebinding protection tests using explicit Host/Origin header manipulation. |
doc/transports.md |
Adds deployment recipes and revises compatibility guidance to keep DNS rebinding protection enabled. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Production-readiness scope
StreamableHTTPServerTransportHost/Origin checks.enableDnsRebindingProtection: trueand document explicit exceptions only for short-lived internal compatibility testing.Test Plan
dart format test/server/streamable_https_test.dartdart test test/server/streamable_https_test.dartdart analyzedart testRefs #98